Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test, implement dual banner fix #456

Merged

Conversation

housepbass
Copy link
Contributor

@housepbass housepbass commented Feb 7, 2024

Implement handling for multiple banner configurations. ie a configuration file containing both banner exec and banner motd

Copy link
Collaborator

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@qduk qduk merged commit 5ad28f7 into networktocode:jkala-dual-banner-test Feb 7, 2024
17 checks passed
itdependsnetworks added a commit that referenced this pull request Feb 9, 2024
* dual banner test case single banner feature search
* Refactor test, implement dual banner fix (#456)
* Refactor test, implement dual banner fix
* Add tests for multiple banners

---------

Co-authored-by: Anthony House <[email protected]>

---------

Co-authored-by: Jeff Kala <[email protected]>
Co-authored-by: housepbass <[email protected]>
Co-authored-by: Anthony House <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants