Update Windstream Parser for new emails #291
Conversation
aliex-13
requested review from
chadell,
glennmatthews,
pke11y,
scetron and
jvanderaa
as code owners
|
Hey @glennmatthews, test email has been added and unit tests updated. |
|
@aliex-13 could you fix the CI tests? |
|
Hey @chadell - I've pushed updates to fix the pylint issues but other issues unrelated to my code are occurring. Any chance you could take a look at the pipeline and let me know. I noticed these when running my own tests internally but didn't want to mess around with other code which was already in this state. |
Yes @aliex-13 , going to fix the doctest |
circuit_maintenance_parser/output.py
Outdated
| @@ -83,7 +83,6 @@ class CircuitImpact(BaseModel, extra="forbid"): | |||
| pydantic_core._pydantic_core.ValidationError: 1 validation error for CircuitImpact | |||
| impact | |||
| Input should be 'NO-IMPACT', 'REDUCED-REDUNDANCY', 'DEGRADED' or 'OUTAGE' [type=enum, input_value='wrong impact', input_type=str] | |||
| ... | |||
There was a problem hiding this comment.
@aliex-13 could you readd this to fix the doctest?
It seems Windstream have updated their emails with an additional table to include GPS location - Lat and Long.
This has messed with the existing parser so i've had to add some additional checks to the parser.
Just re-checks for maint_id, start and end time.
No other changes included.