Calico CI #202
Calico CI #202
Conversation
Mixaster995
force-pushed
the
calico
branch
8 times, most recently
from
760b40d
to
70171f3
Compare
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
calico
branch
5 times, most recently
from
8474b6f
to
673efff
Compare
Mixaster995
force-pushed
the
calico
branch
3 times, most recently
from
cabd036
to
1fdc0d2
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
|
@edwarnicke Finally Calico passes CI. As I can see this PR adds a separate job that runs a few of our tests on packet setup with Calico CNI plugin. For me, these CI changes look overcomplicated, but I think we can go with them for now. Can we merge this and consider simplification a bit after? Please share your thoughts. |
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| version: 1.0 | |||
| root: "./.tests/cloud_test/" | |||
| timeout: 7200 # 2 hour total total timeout | |||
| timeout: 10800 # 3 hour total total timeout | |||
There was a problem hiding this comment.
3 hours is a long timeout... why is it taking that long?
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| calico: ["off", "on"] |
There was a problem hiding this comment.
Might it not make more sense semantically to have this matrix be a matrix for CNI plugin, where calico-vpp is just one of the choices? That would let us have an easy visible path for other CNIs to be added later. Thoughts?
| @@ -79,6 +83,7 @@ jobs: | |||
| - name: Install cloudtest # 3. Install cloudtest | |||
| run: | | |||
| go get github.com/networkservicemesh/cloudtest@master | |||
| # GOPROXY=direct go get github.com/Mixaster995/cloudtest@no-cleanup | |||
There was a problem hiding this comment.
Should this commented line be removed?
| suite.Run(t, new(multiforwarder.Suite)) | ||
| } | ||
|
|
||
| func TestHeal(t *testing.T) { | ||
| if isCalico() { | ||
| t.Skip("not available with Calico") | ||
| } |
There was a problem hiding this comment.
Why are heal tests not available with Calico?
| if !isCalico() { | ||
| t.Skip("not available without Calico") | ||
| } | ||
| suite.Run(t, new(calico.Suite)) |
There was a problem hiding this comment.
Why does calico have its own independent suite instead of simply running the standard test suite?
|
My overall thoughts here are:
|
part of networkservicemesh/integration-k8s-kind#325