Skip to content

Fix relative iris with colons #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix relative iris with colons #1147

merged 1 commit into from
Jan 28, 2025

Conversation

justin-tay
Copy link
Contributor

Closes #1146

Fix the issue where a relative iri with a colon is treated as an absolute iri.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (48ca3c2) to head (1aeea15).
Report is 77 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1147      +/-   ##
============================================
- Coverage     78.90%   78.13%   -0.78%     
- Complexity     1965     2065     +100     
============================================
  Files           172      201      +29     
  Lines          6352     6859     +507     
  Branches       1255     1255              
============================================
+ Hits           5012     5359     +347     
- Misses          867     1033     +166     
+ Partials        473      467       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 6c37935 into networknt:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative IRIs incorrectly resolved if they contain colons
3 participants