Merge pull request #152 from netvvrk/skip-duplicate-chargebee-events

skip duplicate chargebee events

app/lib/webhook_handler.rb

@@ -3,15 +3,20 @@
 class WebhookHandler
   class << self
     def handle_payload(event)
-      cb_event = ChargebeeEvent.new(
-        event_id: event.id,
-        created_at: event.occurred_at,
-        event_type: event.event_type,
-        user_email: event.content.customer&.email,
-        content: event.content
-      )
-      unless cb_event.save
-        Rails.logger.error("ChargebeeEvent failed: #{cb_event.errors.messages}")
+      begin
+        cb_event = ChargebeeEvent.new(
+          event_id: event.id,
+          created_at: event.occurred_at,
+          event_type: event.event_type,
+          user_email: event.content.customer&.email,
+          content: event.content
+        )
+        unless cb_event.save
+          Rails.logger.error("ChargebeeEvent failed: #{cb_event.errors.messages}")
+          return false
+        end
+      rescue ActiveRecord::RecordNotUnique
+        Rails.logger.error("Skipped duplicate ChargebeeEvent #{event.id}")
         return false
       end
 

test/lib/webhook_handler_test.rb

@@ -24,6 +24,21 @@ class WebhookHandlerTest < ActiveSupport::TestCase
     end
   end
 
+  test "duplicate event does not crash" do
+    payload = File.read(Rails.root.join("test", "fixtures", "files", "subscription_created_annual.json"))
+    event = ChargeBee::Event.deserialize(payload)
+
+    assert_difference "ChargebeeEvent.count", 1 do
+      assert_difference "User.count" do
+        assert WebhookHandler.handle_payload(event)
+      end
+    end
+
+    assert_nothing_raised do
+      refute WebhookHandler.handle_payload(event)
+    end
+  end
+
   test "subscripton cancelled" do
     payload = File.read(Rails.root.join("test", "fixtures", "files", "subscription_cancelled.json"))
     event = ChargeBee::Event.deserialize(payload)