Skip to content

Commit

Permalink
Bump to new scionproto version (#242)
Browse files Browse the repository at this point in the history
* Fix imports to new scionproto

* Update go version

* Update go in ci

* Try go 1.17

* Try again Go 1.20

* Install new go version for integration tests

* Pin SCION version in ci tests

* Upgrade to go 1.21

* Update to Go 1.21.3

* Improve comments in circle ci config
  • Loading branch information
martenwallewein authored Oct 16, 2023
1 parent 7775c2e commit 1e8d706
Show file tree
Hide file tree
Showing 14 changed files with 213 additions and 713 deletions.
18 changes: 15 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: cimg/go:1.17
- image: cimg/go:1.21
steps:
- run:
name: Go version
Expand Down Expand Up @@ -48,7 +48,12 @@ jobs:
# name; the format looks like this:
# github.com/scionproto/scion v0.4.1-c0ffeeabc # pseudo-tag followed by commit hash, or
# github.com/scionproto/scion v0.5.0 # actual tag
scion_commit=${scion_mod_version##*[ -]}
# Was previously scion_commit=${scion_mod_version##*[ -]}
# Having the newest scion commit would lead to a lot of upgrades below
# So we pin it to an older version that matches the integration tests
# It should not matter if we build SCION binaries with different version than the apps
# as long as there are no major breaks
scion_commit=5883c725f748 # Previously: v0.6.1-0.20220202161514-5883c725f748; Now: v0.8.1-0.20231010074308-1774cbfccb4c
git clone ${scion_repo} ~/scion
cd ~/scion
git checkout --quiet ${scion_commit}
Expand Down Expand Up @@ -88,6 +93,13 @@ jobs:
dispatcher \
as1-ff00_0_110:cs1-ff00_0_110-1 \
as1-ff00_0_110:sd1-ff00_0_110
# Use different Go version to build scion-apps
- run:
name: Install Go 1.21.3 to build scion-apps
command: |
wget https://go.dev/dl/go1.21.3.linux-amd64.tar.gz
sudo rm -rf /usr/local/go
sudo tar -C /usr/local -xzf go1.21.3.linux-amd64.tar.gz
- run:
name: Integration tests
command: |
Expand All @@ -103,4 +115,4 @@ workflows:
build_and_test:
jobs:
- build
- integration
- integration
2 changes: 1 addition & 1 deletion cmd/rainsd/rainsd.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/netsec-ethz/rains/internal/pkg/libresolve"
"github.com/netsec-ethz/rains/internal/pkg/message"
"github.com/netsec-ethz/rains/internal/pkg/rainsd"
"github.com/scionproto/scion/go/lib/snet"
"github.com/scionproto/scion/pkg/snet"
"github.com/spf13/cobra"
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/rdig/rdig.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/netsec-ethz/rains/internal/pkg/token"
"github.com/netsec-ethz/rains/internal/pkg/util"
"github.com/netsec-ethz/rains/internal/pkg/zonefile"
"github.com/scionproto/scion/go/lib/snet"
"github.com/scionproto/scion/pkg/snet"
flag "github.com/spf13/pflag"
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/zonepub/zonepub.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/netsec-ethz/rains/internal/pkg/publisher"
"github.com/netsec-ethz/rains/internal/pkg/section"
"github.com/netsec-ethz/rains/internal/pkg/zonefile"
"github.com/scionproto/scion/go/lib/snet"
"github.com/scionproto/scion/pkg/snet"
"github.com/spf13/cobra"
)

Expand Down
64 changes: 59 additions & 5 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,14 +1,68 @@
module github.com/netsec-ethz/rains

go 1.16
go 1.21

require (
github.com/britram/borat v0.0.0-20181011130314-f891bcfcfb9b
github.com/inconshreveable/log15 v0.0.0-20180818164646-67afb5ed74ec
github.com/scionproto/scion v0.6.1-0.20220202161514-5883c725f748
github.com/spf13/cobra v1.2.1
github.com/scionproto/scion v0.8.1-0.20231010074308-1774cbfccb4c
github.com/spf13/cobra v1.6.1
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.7.0
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519
github.com/stretchr/testify v1.8.3
golang.org/x/crypto v0.9.0
)

require (
github.com/beorn7/perks v1.0.1 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/dchest/cmac v1.0.0 // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/go-stack/stack v1.8.0 // indirect
github.com/golang/protobuf v1.5.3 // indirect
github.com/google/gopacket v1.1.19 // indirect
github.com/google/uuid v1.3.0 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
github.com/grpc-ecosystem/grpc-opentracing v0.0.0-20180507213350-8e809c8a8645 // indirect
github.com/inconshreveable/mousetrap v1.0.1 // indirect
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.17 // indirect
github.com/mattn/go-sqlite3 v1.14.17 // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
github.com/opentracing/opentracing-go v1.2.0 // indirect
github.com/pelletier/go-toml v1.9.5 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/prometheus/client_golang v1.14.0 // indirect
github.com/prometheus/client_model v0.3.0 // indirect
github.com/prometheus/common v0.37.0 // indirect
github.com/prometheus/procfs v0.8.0 // indirect
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
github.com/uber/jaeger-client-go v2.30.0+incompatible // indirect
github.com/uber/jaeger-lib v2.0.0+incompatible // indirect
go.uber.org/atomic v1.9.0 // indirect
go.uber.org/multierr v1.8.0 // indirect
go.uber.org/zap v1.24.0 // indirect
golang.org/x/mod v0.10.0 // indirect
golang.org/x/net v0.10.0 // indirect
golang.org/x/sync v0.2.0 // indirect
golang.org/x/sys v0.8.0 // indirect
golang.org/x/text v0.9.0 // indirect
golang.org/x/tools v0.9.1 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20230815205213-6bfd019c3878 // indirect
google.golang.org/grpc v1.57.0 // indirect
google.golang.org/protobuf v1.31.0 // indirect
gopkg.in/d4l3k/messagediff.v1 v1.2.1 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
lukechampine.com/uint128 v1.2.0 // indirect
modernc.org/cc/v3 v3.40.0 // indirect
modernc.org/ccgo/v3 v3.16.13 // indirect
modernc.org/libc v1.22.5 // indirect
modernc.org/mathutil v1.5.0 // indirect
modernc.org/memory v1.5.0 // indirect
modernc.org/opt v0.1.3 // indirect
modernc.org/sqlite v1.24.0 // indirect
modernc.org/strutil v1.1.3 // indirect
modernc.org/token v1.0.1 // indirect
)
Loading

0 comments on commit 1e8d706

Please sign in to comment.