Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove extra Hashable conformance for ParseObject #182

Merged
merged 14 commits into from
Sep 2, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Sep 1, 2024

New Pull Request Checklist

Issue Description

Extra conformance left over from changes to ParseTypeable in #176.

Approach

Remove extra conformance.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (b56de0a) to head (3d0a361).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   91.34%   91.31%   -0.04%     
==========================================
  Files         179      179              
  Lines       12162    12175      +13     
==========================================
+ Hits        11109    11117       +8     
- Misses       1053     1058       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 changed the title fix: Remove extra Hashable conformance for ParseObject refactor: Remove extra Hashable conformance for ParseObject Sep 1, 2024
@cbaker6 cbaker6 merged commit 3f02f59 into main Sep 2, 2024
14 checks passed
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch September 2, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant