Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update CustomLinearCareTaskProgress #15

Merged
merged 12 commits into from
Jul 18, 2024

Commits on Jul 10, 2024

  1. refactor: changed the title of OCKEventAggregator.swift to CareTaskPr…

    …ogressStrategy+Math
    
    removed struct CustomLinearCareTaskProgress
    removed all appearances of CustomLinearCareTaskProgress to LinearCareTaskProgress
    lmillan1 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8b61410 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. test: add new test cases for computeProgress functions

    Add new test cases for `computeProgressByAveragingOutcomeValues`, `computeProgressByMedianOutcomeValues`, and `computeProgressByStreakOutcomeValues` functions in the `CareTaskProgressStrategy` class. Covers varioues edge cases and increases overall test coverage.
    
    feat: add kind parameter to computeProgress functions
    
    Add a new `kind` parameter to `computeProgressByAveragingOutcomeValues`, `computeProgressByMedianOutcomeValues`, and `computeProgressByStreakOutcomeValues` functions in the `CareTaskProgressStrategy` class. This allows calculating progress for a specific kind of outcome.
    lmillan1 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e6d2c6e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. refacor: removed force unwrapping

    removes all instances of force unwrapping to prevent potential crashes.
    style: remove underscores for function, remove unnecessary comments, and formatting.
    lmillan1 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f74280b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. test: added test cases for kind field

    Added unit test to verify the handling of different kinds the 'computeProgressByAveragingOutcomeValues' function.
    refacor: simplified value extraction from OCKOutcomeValue
    Replaced instances of $0.numberValue?.doubleValue with $0.doubleValue to remove unnecessary casting.
    style: improved readibility by adding new lines
    lmillan1 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d292ba5 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. fix: avoid force unwrapping in progress calculation tests

    Refactor tests to be able to unwrap optional values using guard statements
    style: Reduced identation and also tab when needed
    refactor: Use string variables for kinds to reduce programatic mistakes
    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6e0e7da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    533f09a View commit details
    Browse the repository at this point in the history
  3. nits

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3b30fa2 View commit details
    Browse the repository at this point in the history
  4. nits

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a876891 View commit details
    Browse the repository at this point in the history
  5. rename count to valueCount

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    57b77c5 View commit details
    Browse the repository at this point in the history
  6. nit

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    25b2306 View commit details
    Browse the repository at this point in the history
  7. nits

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0369832 View commit details
    Browse the repository at this point in the history
  8. nits

    lmillan1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6057e77 View commit details
    Browse the repository at this point in the history