fix filter icmp pointer check (#755)

Signed-off-by: Mohamed Mahmoud <[email protected]> (cherry picked from commit 6faff0a)
netobserv · Sep 3, 2024 · 9bf0a79 · 9bf0a79
1 parent 5219a48
commit 9bf0a79
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/controllers/ebpf/agent_controller.go b/controllers/ebpf/agent_controller.go
@@ -482,28 +482,19 @@ func (c *AgentController) configureFlowFilter(filter *flowslatest.EBPFFlowFilter
 			Value: strconv.Itoa(filter.Ports.IntValue()),
 		})
 	}
-	if *filter.ICMPType != 0 {
+	if filter.ICMPType != nil && *filter.ICMPType != 0 {
 		config = append(config, corev1.EnvVar{Name: envFilterICMPType,
 			Value: strconv.Itoa(*filter.ICMPType),
 		})
 	}
-	if *filter.ICMPCode != 0 {
+	if filter.ICMPCode != nil && *filter.ICMPCode != 0 {
 		config = append(config, corev1.EnvVar{Name: envFilterICMPCode,
 			Value: strconv.Itoa(*filter.ICMPCode)})
 	}
 	if filter.PeerIP != "" {
 		config = append(config, corev1.EnvVar{Name: envFilterPeerIPAddress,
 			Value: filter.PeerIP})
 	}
-	if *filter.ICMPType != 0 {
-		config = append(config, corev1.EnvVar{Name: envFilterICMPType,
-			Value: strconv.Itoa(*filter.ICMPType),
-		})
-	}
-	if *filter.ICMPCode != 0 {
-		config = append(config, corev1.EnvVar{Name: envFilterICMPCode,
-			Value: strconv.Itoa(*filter.ICMPCode)})
-	}
 	return config
 }