NETOBSERV-1076 Fix service change detection (#360)

use DeepDerivative on labels & annotations only, rather than full ObjectMeta
netobserv · Jun 2, 2023 · 6aa0188 · 6aa0188
1 parent 0e4dfd1
commit 6aa0188
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/helper/comparators.go b/pkg/helper/comparators.go
@@ -75,7 +75,8 @@ func probeChanged(old, new *corev1.Probe) bool {
 }
 
 func ServiceChanged(old, new *corev1.Service, report *ChangeReport) bool {
-	return report.Check("Service meta changed", !equality.Semantic.DeepDerivative(new.ObjectMeta, old.ObjectMeta)) ||
+	return report.Check("Service annotations changed", !equality.Semantic.DeepDerivative(new.Annotations, old.Annotations)) ||
+		report.Check("Service labels changed", !equality.Semantic.DeepDerivative(new.Labels, old.Labels)) ||
 		report.Check("Service spec changed", !equality.Semantic.DeepDerivative(new.Spec, old.Spec))
 }