chore(actions): check uncomitted go source code changes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit 08798c8 |
github-actions
bot
added
the
type: chore
JGAntunes
force-pushed
the
chore/actions-verify-go
branch
from
2e9b4da to
08798c8
Compare
erezrokah
approved these changes
Jan 21, 2021
keiko713
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
I remember that @erezrokah and I were talking about these swagger_*.json files the other day for what to do. I think it's safe to add them to .gitignore, so looks good! 👍
mraerino
approved these changes
Jan 21, 2021
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| go_version: [1.14.x] |
There was a problem hiding this comment.
latest is 1.15, do we want to use that?
There was a problem hiding this comment.
Happy to do it, but maybe in that case we should also add it to our Test action - https://github.com/netlify/open-api/blob/master/.github/workflows/test.yml#L34?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up on what has been discussed on #285 and adds a step to verify that the go client is up to date and the files have been checked in (once again based on work @erezrokah did in the CLI 🙏 ). I've tested it in this PR by making some changes to
swagger.ymlfile and not generating a new client - https://github.com/netlify/open-api/runs/1742899676?check_suite_focus=true. - seems solid 😄I've also added two files to the
.gitignore, which I believe are only used as helpers when generating the go glient and don't need to be checked in. Do tell me if that is not the case though.