-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release-please #288
Conversation
✔️ Deploy preview for open-api ready! 🔨 Explore the source changes: f452ce9 🔍 Inspect the deploy logs: https://app.netlify.com/sites/open-api/deploys/60085ddfcc231d00098f3637 😎 Browse the preview: https://deploy-preview-288--open-api.netlify.app |
Thanks @JGAntunes I've added the secret. How are we dealing with generating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, but will delegate to the Backend the rest of the review.
I've added a more extensive comment covering that @erezrokah - #285 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from a process level this looks fine.
this still expects people to manually regenerate the Go client right?
since this has always been the case this is not a blocker: can we think of a process where PRs are denied when the go code is not up-to-date?
that would also block releases that had this problem (but should not if we never merged PRs with failing checks).
@mraerino that's correct yes, I've went through a more lengthy boring explanation here - #285 (comment) - but essentially we can come out with an action to verify if new files are generated through |
This PR partially addresses #285. The idea is to provide a way to tag, release and bump the versions of both
package.json
andswagger.yml
files. I tried running some tests on this repo but unfortunately seems likerelease-please
will always create PRs against the mainline. As such I've ran some tests yesterday on a small repo - JGAntunes/actions-playground#1 - testingauto-commit
. The idea here is to rely on it as a workaround to bump theswagger.yml
file based onpackage.json
version (which is initially done byrelease-please
).For this to work I'll need to add a secret to the repo (currently don't have access, maybe you can help me witht it @erezrokah?), similar to what we've done, maybe we can use
netlify-bot
s access token? - netlify/cli#1778 (comment)