Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add move to options type for cache util exposed to build plugins #6019

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jan 16, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Noticed here - https://github.com/netlify/netlify-plugin-gatsby/pull/753/files#diff-d6feec7c99b0a9ddfead350e1f906b6538249944e8ceff596de691945cbdd064R25-R26 that types that build plugin options have don't have all available options - in this case move option that is actually there and working:


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@pieh pieh marked this pull request as ready for review January 17, 2025 18:00
@pieh pieh requested a review from a team as a code owner January 17, 2025 18:00
@pieh pieh enabled auto-merge (squash) January 20, 2025 08:09
@pieh pieh merged commit c2843db into main Jan 20, 2025
32 of 33 checks passed
@pieh pieh deleted the fix/add-move-to-cache-util branch January 20, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants