feat: handle region: prefix in local server
#164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Skn0tt
reviewed
Apr 3, 2024
| let parts = url.pathname.split('/').slice(1) | ||
|
|
||
| if (parts[0].startsWith(REGION_PREFIX)) { | ||
| parts = parts.slice(1) |
There was a problem hiding this comment.
we're discarding the region parameter, which means that in local dev, stores with different experimentalRegion parameters all share the same data. Is that exepcted?
There was a problem hiding this comment.
I think that's fine for now. We will likely need to rethink the whole namespacing we use locally once we make region selection a customer-facing thing, but I think just ignoring regions for now is an okay first step.
Co-authored-by: Simon Knott <[email protected]>
Skn0tt
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
When using the new
experimentalRegionproperty in a deploy-scoped store in conjunction withedgeURL, the client will send the region in the URL path with aregion:prefix. This PR makes the local server understand that and point requests to the right path on disk.