Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-901 replace decorator service for variation path generator if Netgen Admin UI is enabled #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?php

declare(strict_types=1);

namespace Netgen\Bundle\SiteBundle\Core\Imagine\VariationPathGenerator;

use Ibexa\Contracts\Core\Variation\VariationPathGenerator;
use Liip\ImagineBundle\Imagine\Filter\FilterConfiguration;

use function array_key_exists;
use function pathinfo;
use function preg_replace;

/**
* Decorates VariationPathGenerator with .webp extension if image variation is configured for this format.
*/
final class WebpFormatVariationPathGenerator implements VariationPathGenerator
{
private VariationPathGenerator $innerVariationPathGenerator;

private FilterConfiguration $filterConfiguration;

public function __construct(
VariationPathGenerator $innerVariationPathGenerator,
FilterConfiguration $filterConfiguration,
) {
$this->innerVariationPathGenerator = $innerVariationPathGenerator;
$this->filterConfiguration = $filterConfiguration;
}

public function getVariationPath($originalPath, $filter): string
{
$variationPath = $this->innerVariationPathGenerator->getVariationPath($originalPath, $filter);
$filterConfig = $this->filterConfiguration->get($filter);

if (!isset($filterConfig['format']) || $filterConfig['format'] !== 'webp') {
return $variationPath;
}

$info = pathinfo($originalPath);

if (!array_key_exists('extension', $info) || $info['extension'] === '') {
return $variationPath . '.webp';
}

return preg_replace("/\\.{$info['extension']}$/", '.webp', $variationPath) ?? $variationPath;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php

declare(strict_types=1);

namespace Netgen\Bundle\SiteBundle\DependencyInjection\Compiler;

use Ibexa\Bundle\Core\Imagine\VariationPathGenerator\WebpFormatVariationPathGenerator as BaseWebpFormatVariationPathGenerator;
use Netgen\Bundle\SiteBundle\Core\Imagine\VariationPathGenerator\WebpFormatVariationPathGenerator;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;

use function array_keys;
use function in_array;
use function is_array;

class WebpFormatVariationPathGeneratorDecoratorPass implements CompilerPassInterface
{
/**
* Overrides default Webp image alias variation path generator decorator to comply with legacy variation URL pattern
* We do this only if we have Netgen AdminUI installed (legacy-based administration).
*/
public function process(ContainerBuilder $container): void
{
if (!$container->hasParameter('kernel.bundles') || !is_array($container->getParameter('kernel.bundles'))) {
return;
}

$activatedBundles = array_keys($container->getParameter('kernel.bundles'));

if (!in_array('NetgenAdminUIBundle', $activatedBundles, true)) {
return;
}

if (!$container->has(BaseWebpFormatVariationPathGenerator::class)) {
return;
}

$container
->findDefinition(BaseWebpFormatVariationPathGenerator::class)
->setClass(WebpFormatVariationPathGenerator::class);
}
}
1 change: 1 addition & 0 deletions bundle/NetgenSiteBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ public function build(ContainerBuilder $container): void
$container->addCompilerPass(new Compiler\IoStorageAllowListPass());
$container->addCompilerPass(new Compiler\PHPStormPass(), PassConfig::TYPE_OPTIMIZE);
$container->addCompilerPass(new Compiler\DirectDownloadPass());
$container->addCompilerPass(new Compiler\WebpFormatVariationPathGeneratorDecoratorPass());
}
}
Loading