Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few markdown hyperlinks #961

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mjbear
Copy link

@mjbear mjbear commented Aug 10, 2024

Test inclusion requirements

In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:

  • any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
  • a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
  • any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir

For additional information about tests, follow this link

Related Issue

n/a

Description

Fix the markdown for a couple of hyperlinks in README.md

Type of change

  • Documentation update

New Behavior

None - documentation update

Contrast to Current Behavior

None - documentation update

Discussion: Benefits and Drawbacks

No drawbacks as the documentation changes (hyperlinks) are cosmetic
The fixes adds "polish" to the README.md
Backwards compatibility doesn't apply to my README.md fixes

Changes to the Documentation

This PR is to update documentation.

Proposed Release Note Entry

Fix markdown formatting for a few hyperlinks in README.md

Comments

Relatively minor PR.

I may bring it up elsewhere, but the develop branch is nearly 60 commits behind master. (Or rather master says it is nearly 60 commits ahead of develop.)
My feature branch is off of develop like the contributing docs instructed.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR source branch is created from the develop branch.
  • My PR targets the develop branch.
  • All my commits have --signoff applied

Signed-off-by: Michael Bear <[email protected]>
@mjbear
Copy link
Author

mjbear commented Aug 18, 2024

@ddutt
(I realize this PR is quite minor.)
Please let me know if there are any adjustments I need to make.

Thank you!

@mjbear mjbear changed the title fix a few markdown hyperlinks Fix a few markdown hyperlinks Aug 20, 2024
@ddutt
Copy link
Member

ddutt commented Aug 21, 2024

@ddutt (I realize this PR is quite minor.) Please let me know if there are any adjustments I need to make.

Thank you!

Thanks for the fixes Michael. every little bit helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants