Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify destination fixing issues with CO-RE #53

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Sep 6, 2023

Summary

When ebpf.plugin were classifying the socket origin, it was not able to classify correctly the passive connections, because we were attaching a trampoline to fentry instead fexit. This PR addresses this issue that are not happening in kernel-collector repo.

Test Plan
  1. Clone this branch
  2. Run the following commands:
# git submodule update --init --recursive
# make clean; make
# cd src/tests
# sh run_tests.sh
  1. Verify that you do not have any libbpf error inside error.log.
Additional information
Linux Distribution Environment Kernel Version Error Success
Slackware current Bare metal 6.1.51 slackware_6_1_error.txt slackware_6_1_success.txt

@thiagoftsm thiagoftsm changed the title sync_algoorithms: Modify destination fixing issues with CO-RE Modify destination fixing issues with CO-RE Sep 6, 2023
@thiagoftsm thiagoftsm marked this pull request as draft September 6, 2023 15:18
@thiagoftsm thiagoftsm marked this pull request as ready for review September 6, 2023 17:27
@thiagoftsm thiagoftsm merged commit 52cb532 into netdata:master Sep 6, 2023
7 checks passed
@thiagoftsm thiagoftsm deleted the sync_algoorithms branch September 6, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant