AMS-9968: update links and text #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe you should not have done this. The product links are correct as already available. Only in the en ones you should have made the changes. The de ones is breaking otherwise. |
|
@vdbhb59 Why should we not have done this? These are the new product links that come with the .com website. I have checked all the links and they work fine. |
lukas-kreuzer
approved these changes
Sep 12, 2024
|
DE ones should be changed as per the language. I am not saying not to do it, but just changing the links makes no sense for the German language ones. Those are not rendering the language fully. |
|
@vdbhb59 Sorry but I dont understand what you mean by that. What exactly does "not rendering the language fully" mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ats.anexia-it.com/browse/AMS-9968