Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61: Address a regression in the original fix #70

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jeremystretch
Copy link
Contributor

Fixes: #61

Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in the original repro scenario, but it also works in the original code as it has the fix for 61 in it. So it seems to work, just not sure the fail scenario.

@jeremystretch jeremystretch merged commit 80362e6 into develop Sep 4, 2024
7 checks passed
@jeremystretch jeremystretch deleted the 61-fix-regression branch September 4, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry run sync on a branch results in a ValidationError when the branch is later synced with "commit"
2 participants