Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #122: Implement a mechanism to enforce policy before executing branch actions #124

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jeremystretch
Copy link
Contributor

Fixes: #122

  • Introduce configuration parameters for branch action validators
  • Add can_$action() methods on the Branch model
  • Prevent branch actions from being committed where not permitted by policy
  • Dry runs for sync, merge, and revert are still allowed

Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests added for these, but as there isn't a mock plugin in the test suite I'm assuming it will be for later. Maybe add a FR for creating such a test?

@jeremystretch jeremystretch merged commit 644264f into feature Sep 17, 2024
7 checks passed
@jeremystretch jeremystretch deleted the 122-branch-action-validators branch September 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants