Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #97: Introduce the exempt_models config parameter #109

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jeremystretch
Copy link
Contributor

Fixes: #97

  • Introduce the exempt_models config parameter
  • Change the EXCLUDED_APPS constant to EXEMPT_MODELS
  • Tweak plugin initialization logic to inspect both static & configured exempt models

…ranching support for specific plugin models
Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mention in the docs that the branching plugin must come after any other plugins for the branching support to be enabled for them.

@jeremystretch
Copy link
Contributor Author

@arthanson that's something to be tackled in a separate issue as it's not specific to this FR.

@jeremystretch jeremystretch merged commit be5c2a4 into develop Sep 11, 2024
7 checks passed
@jeremystretch jeremystretch deleted the 97-opt-out-models branch September 11, 2024 18:28
jeremystretch added a commit that referenced this pull request Sep 12, 2024
* Closes #97: Introduce the exempt_models config parameter to disable branching support for specific plugin models

* Add warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a mechanism for other plugins to opt their models out of branching support
2 participants