Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #94: Resolve model field name for custom field data #106

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fixes #94: Resolve model field name for custom field data #106

merged 1 commit into from
Sep 10, 2024

Conversation

jeremystretch
Copy link
Contributor

Fixes: #94

Update update_object() to handle custom field data properly, using the model's custom_field_data field.

arthanson
arthanson approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested develop and repro'd the issue then tested on the branch and worked correctly.

@jeremystretch jeremystretch merged commit d8f1cfd into develop Sep 10, 2024
7 checks passed
@jeremystretch jeremystretch deleted the 94-fix-cf-data branch September 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't Merge Branch When Interfaces Have Custom Fields
2 participants
@jeremystretch @arthanson