-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #84: Introduce the max_active_branches
config parameter
#100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works but I think the nomenclature is confusing. In the branches table there is an "is_active" flag and it is used to denote which branch is currently active, but here we are using active to denote non merged branches.
If this was set and I got the error the first thing I'd do is go look at my branches table to see which ones are not needed, but I see I don't have any active branches (or at most 1) so I'd be like why did I get this message... I think the table should easily show which branches are in the state that this flag refers to.
@arthanson thanks that's a really good catch. Maybe we should refer to these branches as "operational" rather than "active." |
I settled on |
* Closes #84: Introduce the max_active_branches parameter * Rename max_active_branches to max_working_branches * Update error message
Fixes: #84
max_active_branches
config parameter