Skip to content

fix: unmarshal error #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Feb 5, 2025

Fixes an unmarhsal error when retrieving failed deviations when there are details in the database not represented in the output structure.

"failed to convert deviation to proto: failed to unmarshal error: proto:\xc2\xa0(line 1:15): unknown field \"details\""}" >

@ltucker ltucker changed the base branch from develop to feat-postgres-implementation-and-enhancements February 5, 2025 14:55
Copy link

github-actions bot commented Feb 5, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.18s github.com/netboxlabs/diode/diode-server/ingester 75.4% 9 0 0
🟢 PASS 1.06s github.com/netboxlabs/diode/diode-server/migrator 70.4% 4 0 0
🟢 PASS 1.08s github.com/netboxlabs/diode/diode-server/netbox 0.4% 4 0 0
🟢 PASS 1.60s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.41s github.com/netboxlabs/diode/diode-server/reconciler 77.1% 43 0 0
🟢 PASS 1.07s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.28s github.com/netboxlabs/diode/diode-server/reconciler/differ 74.2% 92 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 17.2%

@ltucker ltucker marked this pull request as ready for review February 5, 2025 15:13
@ltucker ltucker merged commit af9d66d into feat-postgres-implementation-and-enhancements Feb 5, 2025
7 checks passed
@ltucker ltucker deleted the fix_unmarshal_error branch February 5, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants