Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some basic open telemetry setup and metrics #244

Open
wants to merge 6 commits into
base: feat-postgres-implementation-and-enhancements
Choose a base branch
from

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Feb 5, 2025

  • sets up open telemetry if requested according to environment config
  • records a few basic measurements of rpc calls, ingestions and startups

etc

This pull request introduces significant enhancements to telemetry and metrics collection in the diode-server project. The changes include adding telemetry setup and metrics recording to the ingester and reconciler components, updating the Docker configuration to support telemetry, and updating dependencies to include OpenTelemetry packages.

Telemetry and Metrics Enhancements:

Dependency Updates:

  • Go Module Dependencies:

Testing Enhancements:

These changes collectively improve the observability and monitoring capabilities of the diode-server components, ensuring better insights into their operation and performance.

Copy link

github-actions bot commented Feb 5, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.24s github.com/netboxlabs/diode/diode-server/ingester 75.0% 9 0 0
🟢 PASS 1.05s github.com/netboxlabs/diode/diode-server/migrator 70.4% 4 0 0
🟢 PASS 1.08s github.com/netboxlabs/diode/diode-server/netbox 0.4% 4 0 0
🟢 PASS 1.64s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.42s github.com/netboxlabs/diode/diode-server/reconciler 69.7% 43 0 0
🟢 PASS 1.07s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.29s github.com/netboxlabs/diode/diode-server/reconciler/differ 74.2% 92 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/telemetry 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 17.5%

@ltucker ltucker marked this pull request as ready for review February 10, 2025 15:28
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants