-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add some basic open telemetry setup and metrics #244
Open
ltucker
wants to merge
6
commits into
feat-postgres-implementation-and-enhancements
Choose a base branch
from
feat_otel_basic
base: feat-postgres-implementation-and-enhancements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add some basic open telemetry setup and metrics #244
ltucker
wants to merge
6
commits into
feat-postgres-implementation-and-enhancements
from
feat_otel_basic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go test coverage
Total coverage: 17.5% |
5d8bc59
to
cf7a8da
Compare
cf7a8da
to
c822a4f
Compare
e763290
to
27d1cf4
Compare
leoparente
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etc
This pull request introduces significant enhancements to telemetry and metrics collection in the
diode-server
project. The changes include adding telemetry setup and metrics recording to the ingester and reconciler components, updating the Docker configuration to support telemetry, and updating dependencies to include OpenTelemetry packages.Telemetry and Metrics Enhancements:
Telemetry Setup and Metrics Recording:
diode-server/cmd/ingester/main.go
: Added telemetry setup, startup counter metric, and Prometheus metrics server initialization. [1] [2]diode-server/cmd/reconciler/main.go
: Added telemetry setup, startup counter metric, ingestion processor metrics, and Prometheus metrics server initialization. [1] [2] [3]diode-server/ingester/component.go
: Integrated metrics recording in theIngest
method and added telemetry attributes. [1] [2] [3] [4] [5] [6] [7]Docker Configuration Updates:
diode-server/docker/docker-compose.yaml
: Added telemetry environment variables and metrics endpoints for Prometheus. [1] [2] [3] [4]diode-server/docker/sample.env
: Added sample telemetry environment variables.Dependency Updates:
diode-server/go.mod
: Updated dependencies to include OpenTelemetry and Prometheus packages. [1] [2]Testing Enhancements:
diode-server/ingester/component_test.go
: Updated tests to include telemetry configuration and metrics setup. [1] [2] [3]These changes collectively improve the observability and monitoring capabilities of the
diode-server
components, ensuring better insights into their operation and performance.