Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diff virtualization.cluster with status #221

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: diff virtualization.cluster with status #221

merged 2 commits into from
Jan 6, 2025

Conversation

mfiedorowicz
Copy link
Member

Fixes #220

@mfiedorowicz mfiedorowicz self-assigned this Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.23s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.04s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.58s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.49s github.com/netboxlabs/diode/diode-server/reconciler 85.0% 64 0 0
🟢 PASS 1.11s github.com/netboxlabs/diode/diode-server/reconciler/applier 88.9% 1 0 0
🟢 PASS 1.51s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.9% 82 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 79.5%

leoparente
leoparente approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfiedorowicz mfiedorowicz merged commit 87855e9 into develop Jan 6, 2025
7 checks passed
@mfiedorowicz mfiedorowicz deleted the fix-diff-virtualization-cluster-with-status branch January 6, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

@ltucker ltucker Awaiting requested review from ltucker ltucker is a code owner

Assignees

@mfiedorowicz mfiedorowicz

Labels
diode-reconciler diode-server go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Change" reported instead of "No Change" for virtualization objects
2 participants
@mfiedorowicz @leoparente