Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pg view for ingestion logs with latest change set only #217

Conversation

mfiedorowicz
Copy link
Member

Fix for v_ingestion_logs_with_change_set postgres view to return only latest change set corresponding to ingestion log.

Note: as it's not released yet, not adding this to next migration with alter, required pg volume deletion and perform initial migration

@mfiedorowicz mfiedorowicz self-assigned this Dec 31, 2024
@mfiedorowicz mfiedorowicz changed the title fix: pg query for ingestion logs with latest change set only fix: pg view for ingestion logs with latest change set only Dec 31, 2024
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.20s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.04s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.60s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.45s github.com/netboxlabs/diode/diode-server/reconciler 83.2% 49 0 0
🟢 PASS 1.10s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.30s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.3% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 74.8%

@mfiedorowicz mfiedorowicz merged commit ef73334 into feat-postgres-implementation-and-enhancements Jan 1, 2025
3 checks passed
@mfiedorowicz mfiedorowicz deleted the fix-ingestion-logs-with-change-set-view branch January 1, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants