Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 release #178

Merged
merged 14 commits into from
Sep 26, 2024
Merged

🚚 release #178

merged 14 commits into from
Sep 26, 2024

Conversation

mfiedorowicz
Copy link
Member

No description provided.

mfiedorowicz and others added 14 commits September 5, 2024 20:55
* remove diode-redis-cli service

to be replaced with migrations

Signed-off-by: Michal Fiedorowicz <[email protected]>

* allow to disable migration with environment variable

Signed-off-by: Michal Fiedorowicz <[email protected]>

* add function to apply migrations

Signed-off-by: Michal Fiedorowicz <[email protected]>

* marshal ingestion log using protojson

this is to allow us correctly marshal/unmarshal protobuf messages into json and back into protobuf when retrieving ingestion logs

Signed-off-by: Michal Fiedorowicz <[email protected]>

* unmarshal ingestion log from redis JSON back to protobuf

Signed-off-by: Michal Fiedorowicz <[email protected]>

* set defaults for virtualization object types

Signed-off-by: Michal Fiedorowicz <[email protected]>

* set default status for dcim device and site if an empty string

Signed-off-by: Michal Fiedorowicz <[email protected]>

* update codeowners

Signed-off-by: Michal Fiedorowicz <[email protected]>

* add tests for migrations

Signed-off-by: Michal Fiedorowicz <[email protected]>

* remove noisy log

Signed-off-by: Michal Fiedorowicz <[email protected]>

* rename ChangeSetError to IngestionError

Signed-off-by: Michal Fiedorowicz <[email protected]>

* improve apply change set error handling

Signed-off-by: Michal Fiedorowicz <[email protected]>

* tidy up

Signed-off-by: Michal Fiedorowicz <[email protected]>

* document MIGRATION_ENABLED env var

Signed-off-by: Michal Fiedorowicz <[email protected]>

* assert retrieved ingested logs

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>
* feat: add golangci-lint gci linter (go package import order)

Signed-off-by: Michal Fiedorowicz <[email protected]>

* fix goimports

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>
* feat: add ingestion log id (ksuid)

Signed-off-by: Michal Fiedorowicz <[email protected]>

* adjust pagination and ingestion metrics collection

Signed-off-by: Michal Fiedorowicz <[email protected]>

* fix tests

Signed-off-by: Michal Fiedorowicz <[email protected]>

* cap max page size and silence invalid next page token (use default offset)

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>
* fix: extract ingested entity from proto

- reason: we are using protobuf data instead of decoding with mapstructure (used mainly for json [stdlib] marshalled structs)
- add methods for converting protobuf entities into netbox corresponding structs
- adjust unit tests

Signed-off-by: Michal Fiedorowicz <[email protected]>

* fix: log retrieving by state as string

Signed-off-by: Michal Fiedorowicz <[email protected]>

* fix sample.env

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>
* feat: redis FT.SEARCH index adjustments

- add fields for producer app name and version
- for most of index fields use TAG instead of TEXT (https://redis.io/docs/latest/develop/interact/search-and-query/advanced-concepts/escaping/)
- update querying and add escaping function

Signed-off-by: Michal Fiedorowicz <[email protected]>

* add test for request ID (UUID)

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>
NETBOX_DIODE_PLUGIN_SKIP_TLS_VERIFY environment variable missing in the docker-compose for diode-reconciler service

Signed-off-by: Michal Fiedorowicz <[email protected]>
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.22s github.com/netboxlabs/diode/diode-server/ingester 4.3% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.60s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.2% 40 0 0
🟢 PASS 1.44s github.com/netboxlabs/diode/diode-server/reconciler 12.4% 65 0 0
🟢 PASS 1.47s github.com/netboxlabs/diode/diode-server/reconciler/changeset 34.2% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

@mfiedorowicz mfiedorowicz merged commit ae69e71 into release Sep 26, 2024
7 checks passed
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants