#129 add community requested source and destination objects #207
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rvveber
force-pushed
the
129_add_community_requested_source_and_destination_objects
branch
from
12dc111 to
7010069
Compare
|
Hi @rvveber - thanks for this, can I ask you take a look at https://netboxlabs.com/docs/netbox/en/stable/plugins/development/migration-v4/ - note the changes to serializers (hence this in conflict currently) |
Yes, i will look at it tomorrow! |
rvveber
force-pushed
the
129_add_community_requested_source_and_destination_objects
branch
from
7010069 to
c0d5ab6
Compare
|
@cruse1977 i rebased onto the new version and updated my commits to solve the conflicts. |
|
@cruse1977 bump |
|
Any update on this? I've bene looking forward to this feature for quite sometime. |
|
Hi @rvveber just wanted you to know this isn't forgotten about - however its a big change. I've merged this into a forked copy of the latest dev to review - looks good so far. |
Yaay, looking forward to this, thanks to all the contributors! |
|
Hi @rvveber and @cruse1977 great feature very much needed ! Thanks a lot for the work !!! |
|
Hi guys @rvveber @cruse1977, I rebase this PR from the latest version of the |
|
@alexis-UE The rebase isn't the issue. |
… only one Source Field can be specified
… only one Source Field can be specified
… only one Destination Field can be specified
…Tabbed Group; Improve Fieldsets
…urces; Add validation to restrict to a single Source
…Tabbed Group; Improve Fieldsets
…urces; Add validation to restrict to a single Source
…d as Tabbed Group
…stinations; Add validation to restrict to a single Destination
…ce column that will display any Source
…ce column that will display any Source
… Destination column that will display any Destination
…s Tabbed Group; Improve Fieldsets
…s Tabbed Group; Improve Fieldsets
…yed as Tabbed Group
…ple sources; Add validation to restrict to a single Source
…ple sources; Add validation to restrict to a single Source
…ple destinatiions; Add validation to restrict to a single Destination
rvveber
force-pushed
the
129_add_community_requested_source_and_destination_objects
branch
from
c0d5ab6 to
7558f08
Compare
Pull Request
Related Issue
closes #129
New Behavior
This Merge Request, enables to specify various new
SourceEntities for theStandardandExtendedACL Rules.It additionally enables to specify the same Entities as a
Destinationfor theExtendedACL Rule.The new selectable entities are all from the IPAM model group:
I have built in constraints and validation to prevent assigning more than one source/destination.
Therefore adding community requested entities, while keeping the functionality the same.
No changes to the API, except these newly added fields:
source_iprange,source_ipaddress,source_aggregate,source_serviceand
destination_iprange,destination_ipaddress,destination_aggregate,destination_service...
Contrast to Current Behavior
Previously you could only assign a Prefix as Source and Destination.
Now you can assign a Prefix, an IP-Range, an IP-Address, an Aggregate or a Service.
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
Added requested models for selection as source/destination: IP-Range, IP-Address, Aggregate, Service.
...
Double Check
or in a linked issue.
devbranch.