Skip to content

Cable Matters variant of 1U keystone patch panel #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kquinsland
Copy link
Contributor

Re open PR using different incoming branch

Karl Quinsland and others added 4 commits June 23, 2025 18:28
appease the linter :)
ComputeBlade and similar. Still very much a WIP, especially the cm4/5.
Re open PR using different incoming branch
@Copilot Copilot AI review requested due to automatic review settings June 24, 2025 17:51
@kquinsland
Copy link
Contributor Author

This replaces: #3266

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new YAML file defining the Cable Matters 24 Port Keystone Patch Panel device with detailed specifications.

  • Introduces a new device type file with manufacturer, model, part number, and module bay information.
  • Defines 24 module bays in a sequential layout.

Comment on lines +17 to +63
position: '1'
- name: '2'
position: '2'
- name: '3'
position: '3'
- name: '4'
position: '4'
- name: '5'
position: '5'
- name: '6'
position: '6'
- name: '7'
position: '7'
- name: '8'
position: '8'
- name: '9'
position: '9'
- name: '10'
position: '10'
- name: '11'
position: '11'
- name: '12'
position: '12'
- name: '13'
position: '13'
- name: '14'
position: '14'
- name: '15'
position: '15'
- name: '16'
position: '16'
- name: '17'
position: '17'
- name: '18'
position: '18'
- name: '19'
position: '19'
- name: '20'
position: '20'
- name: '21'
position: '21'
- name: '22'
position: '22'
- name: '23'
position: '23'
- name: '24'
position: '24'
Copy link
Preview

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] If supported by the schema, consider using numeric values for the 'position' field (e.g., position: 1) to better reflect its numeric nature and simplify downstream processing.

Suggested change
position: '1'
- name: '2'
position: '2'
- name: '3'
position: '3'
- name: '4'
position: '4'
- name: '5'
position: '5'
- name: '6'
position: '6'
- name: '7'
position: '7'
- name: '8'
position: '8'
- name: '9'
position: '9'
- name: '10'
position: '10'
- name: '11'
position: '11'
- name: '12'
position: '12'
- name: '13'
position: '13'
- name: '14'
position: '14'
- name: '15'
position: '15'
- name: '16'
position: '16'
- name: '17'
position: '17'
- name: '18'
position: '18'
- name: '19'
position: '19'
- name: '20'
position: '20'
- name: '21'
position: '21'
- name: '22'
position: '22'
- name: '23'
position: '23'
- name: '24'
position: '24'
position: 1
- name: '2'
position: 2
- name: '3'
position: 3
- name: '4'
position: 4
- name: '5'
position: 5
- name: '6'
position: 6
- name: '7'
position: 7
- name: '8'
position: 8
- name: '9'
position: 9
- name: '10'
position: 10
- name: '11'
position: 11
- name: '12'
position: 12
- name: '13'
position: 13
- name: '14'
position: 14
- name: '15'
position: 15
- name: '16'
position: 16
- name: '17'
position: 17
- name: '18'
position: 18
- name: '19'
position: 19
- name: '20'
position: 20
- name: '21'
position: 21
- name: '22'
position: 22
- name: '23'
position: 23
- name: '24'
position: 24

Copilot uses AI. Check for mistakes.

Karl Quinsland added 3 commits June 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant