-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: refactor com.github.johnfactotum.Foliate into foliate.profile #6582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a profile and a firecfg entry for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @rusty-snake mentioned, the existing profile should probably be refactored
into a new foliate.profile.
That is:
- Move everything into foliate.profile
- Leave just
private-bin com.github.johnfactotum.Foliate
in
com.github.johnfactotum.Foliate.profile and make it be a redirect to
foliate.profile - Add
private-bin foliate
to foliate.profile - Add foliate to firecfg.config
Also, please edit the PRs to allow edits/force pushes, as it makes it much
easier to fix misc issues, especially when opening 10 PRs at once:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo these changes:
- https://github.com/netblue30/firejail/compare/0d74058e04441d076c70b31436dec86142443767..1346f0d80058d3a145d715ba33800ef28078e076#diff-0360cc4907b00da8d92fbeedd7eee00c1b3669a28af160fa1a3b93264831cf9c
- https://github.com/netblue30/firejail/compare/0d74058e04441d076c70b31436dec86142443767..1346f0d80058d3a145d715ba33800ef28078e076#diff-276dcb9ef8e39cdf7549c772fbc137b7711be8d6b59fe1edd849b8798971a161
Misc: It looks like the issue was rebasing on master before running just git pull --rebase
to get the changes from a few days ago:
On Gentoo Linux, there is `/usr/bin/foliate` instead of `/usr/bin/com.github.johnfactotum.Foliate`.
Relates to #6580.