Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: refactor com.github.johnfactotum.Foliate into foliate.profile #6582

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

amano-kenji
Copy link
Contributor

@amano-kenji amano-kenji commented Dec 27, 2024

Relates to #6580.

@rusty-snake rusty-snake self-requested a review December 27, 2024 17:01
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a profile and a firecfg entry for it?

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @rusty-snake mentioned, the existing profile should probably be refactored
into a new foliate.profile.

That is:

  • Move everything into foliate.profile
  • Leave just private-bin com.github.johnfactotum.Foliate in
    com.github.johnfactotum.Foliate.profile and make it be a redirect to
    foliate.profile
  • Add private-bin foliate to foliate.profile
  • Add foliate to firecfg.config

Also, please edit the PRs to allow edits/force pushes, as it makes it much
easier to fix misc issues, especially when opening 10 PRs at once:

@kmk3 kmk3 changed the title profiles: foliate: add foliate to private-bin profiles: refactor com.github.johnfactotum.Foliate into foliate.profile Dec 28, 2024
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Gentoo Linux, there is `/usr/bin/foliate` instead of
`/usr/bin/com.github.johnfactotum.Foliate`.
@kmk3 kmk3 merged commit 9aaf505 into netblue30:master Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants