Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: prismlauncher #6558

Merged
merged 7 commits into from
Dec 17, 2024
Merged

New profile: prismlauncher #6558

merged 7 commits into from
Dec 17, 2024

Conversation

xplanthris
Copy link
Contributor

Created a firejail profile for prismlauncher, I've attempted to limit it as much as possible while allowing Minecraft to run.
As for Downloads, PrismLauncher can get files from Downloads, I'm not sure for what so I have set it to read-only.
If anyone has any ideas on improvement let me know.

@xplanthris
Copy link
Contributor Author

Also unrelated but if this does get merged, will it override my current profile and get everything running as if this was an in-built profile?

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the profile template. It gives you a lot of suggestion for further hardening your prismlauncher profile and keeps profiles consistent.

@rusty-snake rusty-snake marked this pull request as draft November 30, 2024 18:00
@xplanthris
Copy link
Contributor Author

Please follow the profile template. It gives you a lot of suggestion for further hardening your prismlauncher profile and keeps profiles consistent.

Yeah apologies for that, I just used the Firejail configuration tool and modified it, will fix.

@kmk3 kmk3 changed the title Create profile for prismlauncher New profile: prismlauncher Dec 1, 2024
@xplanthris xplanthris marked this pull request as ready for review December 1, 2024 16:21
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good. Maybe we can harden it a bit more.

etc/profile-m-z/prismlauncher.profile Outdated Show resolved Hide resolved
etc/profile-m-z/prismlauncher.profile Outdated Show resolved Hide resolved
include disable-common.inc
include disable-interpreters.inc
include disable-proc.inc
include disable-shell.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every added include disable-*.inc is a win, you can try to add more.

etc/profile-m-z/prismlauncher.profile Show resolved Hide resolved
include disable-shell.inc

whitelist ${HOME}/.local/share/PrismLauncher
whitelist ${HOME}/Downloads
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every added include whitelist-*-common.inc is a win, you can try to add more.

etc/profile-m-z/prismlauncher.profile Show resolved Hide resolved
etc/profile-m-z/prismlauncher.profile Show resolved Hide resolved
@netblue30 netblue30 merged commit 4bca748 into netblue30:master Dec 17, 2024
8 checks passed
@netblue30
Copy link
Owner

Thanks for the patch, merging in! @xplanthris, give it a try and bring in any other fixes if necessary.

@xplanthris
Copy link
Contributor Author

Thanks netblue30!

@netblue30
Copy link
Owner

no problem

kmk3 added a commit that referenced this pull request Dec 23, 2024
kmk3 added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants