Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: nicotine: allow dconf and fix fcitx (dbus) #6036

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

glu8716
Copy link
Contributor

@glu8716 glu8716 commented Oct 6, 2023

From #6034. Nicotine+ needs dbus-user.own org.nicotine_plus.Nicotine or it will crash if started with options for Fcitx. And dbus-user.talk ca.desrt.dconf is to support dconf as stated here.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a replacement and the Fcitx dbus filter.

@glitsj16 glitsj16 changed the title Update nicotine.profile to prevent it from crashing at start if Fcitx options are set + option for dconf nicotine: support Fcitx and dconf via dbus-user filter Oct 6, 2023
@glu8716 glu8716 requested a review from glitsj16 October 6, 2023 13:46
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glitsj16 glitsj16 merged commit 983402e into netblue30:master Oct 7, 2023
@kmk3 kmk3 changed the title nicotine: support Fcitx and dconf via dbus-user filter profiles: nicotine: support Fcitx and dconf via dbus-user filter Sep 2, 2024
@kmk3 kmk3 changed the title profiles: nicotine: support Fcitx and dconf via dbus-user filter profiles: nicotine: allow dconf and fix fcitx (dbus) Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants