Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation and table of contents highlighting issues #169

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix navigation and table of contents highlighting issues #169

merged 3 commits into from
Mar 15, 2024

Conversation

heisbrot
Copy link
Contributor

Table of contents navigation

  • Increased offset to get the correct highlight

Left side navigation

  • Clicking on an accordion when a child page was active would previously redirect to the first page of that accordion. Now if a child page is active clicking the accordion will just close and open it.
  • Fixed an issue with highlighting on direct page visits

@heisbrot heisbrot requested a review from braginini March 14, 2024 12:15
@braginini braginini merged commit 6a97841 into main Mar 15, 2024
1 check passed
@braginini braginini deleted the fix/navigation-scrollspy branch March 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braginini braginini braginini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heisbrot @braginini