This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
scanner subscribed to network device request #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fixes #91 |
|
Code is sharp and precise, works locally. I will test on other devices before publishing to |
|
Thank you for the opportunity. That was my 1st PR |
|
It has been a pleasure – we welcome all contributors to the project and hopefully we have many more like you, @ankitkhedekar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanner subscribed to a
network/device/requestto which it responds with the cached list of devices in network.The devices component publishes to it on
componentWillMount