Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support route_control #248

Merged
merged 82 commits into from
Jan 16, 2025
Merged

Update to support route_control #248

merged 82 commits into from
Jan 16, 2025

Conversation

ccoueffe
Copy link
Collaborator

@ccoueffe ccoueffe commented Dec 10, 2024 •
edited
Loading

Related Issue(s)

Fix the following issues:

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay_services
  • vxlan.overlay_extensions
  • vxlan.policy
  • defaults.vxlan
  • other

Proposed Changes

This change includes templates to generate policies for:

  • Route-map
  • Prefix-list (IPv4 and IPv6)
  • Communities (Standard and Extended)
  • IP AS-Path
  • MAC-List
  • ACLs (IPv4 and IPv6)
  • Time-Range for ACLs
  • Object-Groups (IPv4 and IPv6) for ACLs

Test Notes

Cisco NDFC Version

Tested with ND3.2(1i)

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

juburnet and others added 30 commits November 8, 2024 10:45
@juburnet
new prep plugin for route_control
b2a7850
@juburnet
adding jinja templates
6e7e337
@juburnet
adding jinja template for prefix list
ea4362c
@juburnet
update names to match data model
a9848eb
@juburnet
updated item names
3cf877c
@juburnet
updated order of jinja templates
cc405d2
@juburnet
updated for ipv4_prefix_lists
e40b888
@ccoueffe
add fixes for prep_108 + initial part for IPv4 ACL with Debug
f4789ab
@ccoueffe
update IPv4 ACL template
d3d568f
@ccoueffe
update route-control
edefbe0
@ccoueffe
cleaning debug
c3f834e
@ccoueffe
add time-range and update ipv4 ACL
16912c5
@ccoueffe
add code for time range
b324f59
@ccoueffe
add object-group
b3ba3b2
@GaetanoCarlucci
adding ndfc_mac_list.j2
8337723
@ccoueffe
add first part for IPv6 ACL
99ce653
@ccoueffe
update ACL and add fragment and ignore_routage
3691e3d
@ccoueffe
create initial template for community, ACL: rename range_start/range_…
62b4a47 
…end to from/to and replace netmask by hostmask
@ccoueffe
add code for IP Pfx
796abd6
@ccoueffe
add extension_header for IPv6 ACL
f4bfd14
@juburnet
started route_map jinja
97dbf2d
@ccoueffe
rename entrie to entry
f89196e
@ccoueffe
add code for community list
38bdd77
@ccoueffe
update prep_108 to support hwaddr filter and used in ip ext community…
c831598 
…_list
@GaetanoCarlucci
adding route control rule. temp id 505
34e8a5c
@GaetanoCarlucci
adding route control rule. temp id 505
a460dae
@GaetanoCarlucci
cleaning 505_policy_route_control_route_map.py code
d504913
@GaetanoCarlucci
cleaning 505_policy_route_control_route_map.py code
db273b5
@ccoueffe
update route_maps based on change in schema
ec0a124
@GaetanoCarlucci
verity that route_control exists in data source
98fe856
@ccoueffe
merge import in prep_108,
a9e6d18 
move main jinja route_control out of the folder.
remove ansible.builtin.meta for sub_main
@ccoueffe ccoueffe added the ready for review PR Ready for Review label Dec 13, 2024
ccoueffe and others added 3 commits December 17, 2024 09:14
@ccoueffe
rename function with "update_" and merge code for IPv4 and IPv6 ACLs.
067c210
@ccoueffe
add | sort(attribute='seq_number') to reorder sequence number to all …
7865ae9 
…route_control templates

in ndfc_prefix_list.j2, update entry["prefix"] with filter {{ entry["prefix"] | ipaddr('network/prefix') }} in case or prefix is not the supernet.
Ex: 172.17.1.0/19 is part of 172.17.0.0/19. CLI should have 172.17.0.0/19 else there is an out-of-sync.
@ccoueffe
Merge branch 'netascode:develop' into route_control
2468349
@ccoueffe ccoueffe requested a review from mikewiebe December 20, 2024 19:42
@mikewiebe
Copy link
Collaborator

Charly still needs to address a mapping case with ICMP before we can merge this PR.

@juburnet
Copy link
Collaborator

@mikewiebe - this was updated for ICMP mapping. Please review and merge

juburnet
juburnet approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@juburnet juburnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. It was agreed on a previous call to keep Port numbers only and have the translation to avoid the out-of-sync

@mikewiebe mikewiebe merged commit 4e34cd3 into netascode:develop Jan 16, 2025
6 checks passed
This was referenced Jan 23, 2025
Closed
Closed
Closed
@ccoueffe ccoueffe deleted the route_control branch January 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtarking mtarking mtarking requested changes

@mikewiebe mikewiebe mikewiebe approved these changes

@juburnet juburnet juburnet approved these changes

@devegupt devegupt Awaiting requested review from devegupt

Assignees
No one assigned
Labels
ready for review PR Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccoueffe @mikewiebe @juburnet @mtarking @GaetanoCarlucci