-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Java 1.8 → 11, Tomcat 8.5 → 9 and Solr 7 → 9 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yback into 331_major_upgrade
The current test setup is with Solr 9.1.0 as bumping to 9.2+ introduced incompatibilities. However, the Solr 9.1.0 has a peculiar dependency on Lucene codec 9.2.0. Neither of these things are ideal, but this is "only" testing.
# Conflicts: # src/bundle/README.md
would result in a corpus much larger and having other entries as well.
thomasegense
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and also backwards compatible to solr7 index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades Java, Tomcat & Solr. The Java and Tomcat bumps are near-trivial, but the Solr 7 → 9 bump introduces several changes. Besides updates to the code, the README for building a bundle (
src/bundle/README.md
) has been substantially extended. I suggest following that playbook and testing the produced bundle.With the Solr upgrade comes a switch from Standalone to Cloud. This is not strictly necessary, but running in Cloud mode enables the use of Solr streaming, which has proven useful for flexible exports. There is near-zero penalty to running in Cloud, when using the bundle, as the only change from a user-perspective is the additional
-c
switch when starting Solr.I have added both @thomasegense and @VictorHarbo as reviewers - we should test all the different features of SolrWayback due to the double Solr version jump.
SolrWayback should still be backwards compatible with Solr 7. This is fairly easy to test by starting an existing Solr 7 installation instead of a new Solr 9.
This closes #331