-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates #2248
Doc updates #2248
Conversation
In particular, mention the important fact that throttling happens by user and by endpoint.
@jmcdo29 would you have time to take a look at this PR one of these days? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick view everything looks good. I might suggest we just link over to the nest docs site, but this works too. Thanks for the updates
Cool, thanks! @jmcdo29 you'd have to do the actual merge, since I don't have write access to the repository. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The readme was outdated in several places. There was no good description of the throttling logic.
What is the new behavior?
I've added a short description of the logic. Also, fixed some stale links and clarified some code examples.
Does this PR introduce a breaking change?