Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type definitions and fix arrow function param #2979

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomaszwysocki
Copy link
Contributor

I modified the User type to include the appropriate values. Additionally, I enclosed a sole arrow function parameter in parentheses, following the same convention enforced by Nest's Prettier.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

I modified the User type to include the appropriate values. Additionally, I enclosed a sole arrow function parameter in parentheses, following the same convention enforced by Nest's Prettier.
Co-authored-by: Micael Levi L. Cavalcante <[email protected]>
Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should make this example more complete and complicated (to TS newbies) tho

@tomaszwysocki
Copy link
Contributor Author

I believe this is a rather straightforward example, and verifying that utility type shouldn't pose much difficulty. In my opinion, it aligns well with Nest's methodology of avoiding longer explanations, encouraging readers to explore on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants