Add CoCo to check if the random number functions in NEST #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you say this PR fixes #804 and it can be closed? |
clinssen
reviewed
Sep 26, 2024
clinssen
reviewed
Sep 26, 2024
tests/nest_tests/resources/random_functions_illegal_neuron.nestml
Outdated
Show resolved
Hide resolved
|
Thanks, this looks great other than some very small comments! |
clinssen
reviewed
Sep 26, 2024
fix code generator options handling
clinssen
approved these changes
Oct 2, 2024
|
Bencher Report| Branch | 1104/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse | 📈 view plot | 4,072,677,984.60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CoCo checks if the functions associated with random numbers are used only in the
updateblock. This CoCo applies only to the NEST simulator as using them instate,parameters, andinternalsblocks can lead to unexpected results.Fixes #804