Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refine ci for spam detection #3295

Merged
merged 2 commits into from
Jan 9, 2025
Merged

ci: refine ci for spam detection #3295

merged 2 commits into from
Jan 9, 2025

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Jan 9, 2025

  1. fix the accessibility issue of secrets, github.secrets doesn't work when the permissions field is set
  2. fix the regexp to include http:// when checking if a link is external

@Keith-CY Keith-CY merged commit a6be675 into develop Jan 9, 2025
21 of 24 checks passed
@Keith-CY Keith-CY deleted the refine-spam-detection branch January 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

@yanguoyu yanguoyu Awaiting requested review from yanguoyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keith-CY @homura