Support "amend a pending transaction"

[devchenyan]

issue: Magickbase/neuron-public-issues#332

Screen-2024-02-27-160430.mp4

[Danie0918]

@yanguoyu @homura Please have a review.

[homura]

I'm not sure if the AmendTransaction entity is necessary for this PR. The amendHash appears to be the same as the original transaction's hash on their feature, which makes me wonder if we can remove AmendTransaction.

To implement the amends transaction feature in Neuron, we would need to:

1. Add an "amend" button for each pending transaction.
2. Create an "amend" page that allows users to increase the transaction fee.
3. Fetch the minimal RBF fee and use it as the default amend fee.
4. Send the amended transaction.

In my opinion, the AmendTransaction is unnecessary for this feature and could be removed.

[Danie0918]

@homura @yanguoyu Please have a review.

[Danie0918]

@homura Please have a review.

[silySuper]

/package

[silySuper]

I can not see amend feature in this package for mac-arm 64:https://github.com/nervosnetwork/neuron/actions/runs/8169785200?pr=3045

[devchenyan]

/package

[silySuper]

1.After amend twice(0.00000601 CKB-->0.00001502 CKB-->0.00002403 CKB )，2403 fee transaction will failed,lower fee will disappear.After a while 1502 fee transaction status shows confirming.

2024-03-11.15.45.02.mov

2.Send to address can not see whole in amend page.

3.Failed status can not see in history sometimes,but can see somtimes.Also as amend feature shows when transaction is pending status (data in 2024-03-11 is amend transation),Why?

@devchenyan

[Danie0918]

3.Failed status can not see in history sometimes,but can see somtimes.Also as amend feature shows when transaction is pending status (data in 2024-03-11 is amend transation),Why?

This feature is intended to solve the problem of pending transactions not being able to be packaged and therefore provides modification operations only in the pending state.

As for the failure state not being visible, it may be related to the requirement. #Magickbase/neuron-public-issues#332 (comment)

[silySuper]

4.sudt transaction amend will throw error.

[silySuper]

5.sudt amend page is not correct.In expect it should like sudt send page ，but actually is like this:

sudt page:

[silySuper]

6.ckb asset account receive lost amend feature.

2024-03-11.17.09.27.mov

[devchenyan]

/package

@silySuper https://github.com/nervosnetwork/neuron/actions/runs/8239334131

[silySuper]

All is same as before ,please check whether it is the testing package

[devchenyan]

new package: https://github.com/nervosnetwork/neuron/actions/runs/8243778785/attempts/1

[silySuper]

/package

[yanguoyu]

/package
Packaging for test is done in 8244834788. @yanguoyu

[silySuper]

1.verified
2.verified
3.verified
4.same as before

5.verified
6.not need to change

[silySuper]

7.amend page verify custom price will cause automatic return to home page.

2024-03-12.15.14.40.mov

[devchenyan]

/package
Packaging for test is done in 8253604787. @devchenyan

[silySuper]

4.verified
7.verified

[silySuper]

8.Amend transaction send pageshows abnormal when transaction sent by consuming cell(cell management)

9.In Nervos Dao ,amend trasaction type is changed to sent,in expect it should shows Nervos Dao

[devchenyan]

/package
Packaging for test is done in 8261934198. @devchenyan

[silySuper]

8.verified
9.verified