Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove rebuild index of separated indexer #2990

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Dec 15, 2023

Refer to Magickbase/neuron-public-issues#330

refresh.cache.mov

packages/neuron-ui/src/locales/en.json Outdated Show resolved Hide resolved
@homura
Copy link
Collaborator

homura commented Dec 15, 2023

It would be helpful if the description provided some context or reason for this PR

@yanguoyu yanguoyu force-pushed the feat-remove-rebuild-index branch from 8695b82 to 4da35cc Compare December 15, 2023 03:48
@Keith-CY
Copy link
Collaborator

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

@yanguoyu
Copy link
Collaborator Author

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

I have added the issue that refers to this PR at #2990 (comment)

@Keith-CY
Copy link
Collaborator

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

I have added the issue that refers to this PR at #2990 (comment)

I see, please review again @homura

Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is LGTM, and I'd suggest that the tile could be changed to "remove rebuild index of separated indexer"

@yanguoyu yanguoyu changed the title feat: Remove rebuild indexer feat: Remove rebuild index of separated indexer Dec 19, 2023
@silySuper
Copy link
Collaborator

silySuper commented Dec 26, 2023

/package
Packaging for test is done in 7325706624. @silySuper

@Keith-CY Keith-CY added this pull request to the merge queue Dec 26, 2023
Merged via the queue into nervosnetwork:develop with commit 4af44ea Dec 26, 2023
10 checks passed
@yanguoyu yanguoyu deleted the feat-remove-rebuild-index branch December 26, 2023 09:22
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants