Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address input issue #2918

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: address input issue #2918

merged 2 commits into from
Nov 9, 2023

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented Nov 2, 2023 •
edited
Loading

issue: Magickbase/neuron-public-issues#311

Screen-2023-11-06-153746.mp4

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 2, 2023

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 6, 2023

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

cc @devchenyan

@devchenyan
Copy link
Collaborator Author

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

cc @devchenyan

updated, please review

@devchenyan
Copy link
Collaborator Author

please review @yanguoyu @Keith-CY

@devchenyan devchenyan requested a review from Keith-CY November 9, 2023 05:40
@devchenyan
Copy link
Collaborator Author

devchenyan commented Nov 9, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 6808674929. @devchenyan

@devchenyan devchenyan requested a review from silySuper November 9, 2023 07:27
@devchenyan devchenyan mentioned this pull request Nov 9, 2023
Closed
@devchenyan devchenyan added this pull request to the merge queue Nov 9, 2023
Merged via the queue into nervosnetwork:develop with commit 5e33fe9 Nov 9, 2023
@devchenyan devchenyan deleted the fix-issue_250 branch November 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devchenyan @Keith-CY @yanguoyu @silySuper