Merge some fixes into rc/v0.110.3 #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Keith-CY
commented
Sep 28, 2023
Keith-CY
commented
- fix the label of a text field
- fix transaction generation in Nervos DAO panel
* fix: Fix styles when desc or symbol is overlong * fix: Use difference functions for back and close dialog * fix: Show the error dialog when send transaction and reset deposit value when the dialog opens. * fix: Fix overflow text style * fix: Adapt form submit event * fix: When get transaction error ignore update transaction
Keith-CY
requested review from
zhangyouxin,
homura,
WhiteMinds,
devchenyan,
yanguoyu,
FrederLu and
silySuper
yanguoyu
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.