Merge pull request #1973 from nervosnetwork/hotfix/0.34.2

hotfix 0.34.2

CHANGELOG.md

@@ -1,3 +1,15 @@
+# 0.34.2 (2020-12-31)
+
+[CKB v0.35.1](https://github.com/nervosnetwork/ckb/releases/tag/v0.35.1) was released on Sept. 14th, 2020. This version of CKB node is now bundled and preconfigured in Neuron. 
+
+### Hotfix
+
+* Update the CKB logo.
+* Rename the default network name to `Default`.
+* Fix version updater error when clicking the install button too soon.
+* Fix bug of `too many open files` error.
+
+
 # 0.34.1 (2020-12-19)
 
 [CKB v0.35.1](https://github.com/nervosnetwork/ckb/releases/tag/v0.35.1) was released on Sept. 14th, 2020. This version of CKB node is now bundled and preconfigured in Neuron. 

lerna.json

@@ -2,7 +2,7 @@
   "packages": [
     "packages/*"
   ],
-  "version": "0.34.1",
+  "version": "0.34.2",
   "npmClient": "yarn",
   "useWorkspaces": true
 }

package.json

@@ -2,7 +2,7 @@
   "name": "neuron",
   "productName": "Neuron",
   "description": "CKB Neuron Wallet",
-  "version": "0.34.1",
+  "version": "0.34.2",
   "private": true,
   "author": {
     "name": "Nervos Core Dev",

packages/neuron-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "neuron-ui",
-  "version": "0.34.1",
+  "version": "0.34.2",
   "private": true,
   "author": {
     "name": "Nervos Core Dev",

packages/neuron-wallet/package.json

@@ -3,7 +3,7 @@
   "productName": "Neuron",
   "description": "CKB Neuron Wallet",
   "homepage": "https://www.nervos.org/",
-  "version": "0.34.1",
+  "version": "0.34.2",
   "private": true,
   "author": {
     "name": "Nervos Core Dev",
@@ -85,7 +85,7 @@
     "electron-notarize": "0.2.1",
     "jest-when": "2.7.2",
     "lint-staged": "9.2.5",
-    "neuron-ui": "0.34.1",
+    "neuron-ui": "0.34.2",
     "rimraf": "3.0.0",
     "ttypescript": "1.5.10"
   }

packages/neuron-wallet/src/controllers/update.ts

@@ -64,7 +64,10 @@ export default class UpdateController {
     })
 
     autoUpdater.on('download-progress', progress => {
-      this.notify(progress.percent / 100)
+      const progressPercent = progress.percent / 100
+      if (progressPercent !== 1) {
+        this.notify(progressPercent)
+      }
     })
 
     autoUpdater.on('update-downloaded', () => {

packages/neuron-wallet/src/services/networks.ts

@@ -14,7 +14,7 @@ const presetNetworks: { selected: string, networks: Network[] } = {
   networks: [
     {
       id: 'mainnet',
-      name: 'Mainnet',
+      name: 'Default',
       remote: 'http://localhost:8114',
       genesisHash: MAINNET_GENESIS_HASH,
       type: NetworkType.Default,

packages/neuron-wallet/src/services/sdk-core.ts

@@ -2,14 +2,29 @@ import CKB from '@nervosnetwork/ckb-sdk-core'
 import https from 'https'
 import http from 'http'
 
+let httpsAgent: https.Agent
+let httpAgent: http.Agent
+
+const getHttpsAgent = () => {
+  if (!httpsAgent) {
+    httpsAgent = new https.Agent({ keepAlive: true })
+  }
+  return httpsAgent
+}
+
+const getHttpAgent = () => {
+  if (!httpAgent) {
+    httpAgent = new http.Agent({ keepAlive: true })
+  }
+  return httpAgent
+}
+
 export const generateCKB = (url: string): CKB => {
   const ckb = new CKB(url)
   if (url.startsWith('https')) {
-    const httpsAgent = new https.Agent({ keepAlive: true })
-    ckb.rpc.setNode({ url, httpsAgent })
+    ckb.rpc.setNode({ url, httpsAgent: getHttpsAgent() })
   } else {
-    const httpAgent = new http.Agent({ keepAlive: true })
-    ckb.rpc.setNode({ url, httpAgent })
+    ckb.rpc.setNode({ url, httpAgent: getHttpAgent() })
   }
   return ckb
 }

packages/neuron-wallet/tests/services/networks.test.ts

@@ -150,8 +150,8 @@ describe(`Unit tests of networks service`, () => {
   })
 
   describe(`validation on network existence`, () => {
-    it(`create network with existing name of Mainnet`, () => {
-      expect(service.create('Mainnet', 'http://localhost:8114')).rejects.toThrowError(t(ERROR_MESSAGE.NAME_USED))
+    it(`create network with existing name of Default`, () => {
+      expect(service.create('Default', 'http://localhost:8114')).rejects.toThrowError(t(ERROR_MESSAGE.NAME_USED))
     })
 
     it(`update network which is not existing`, () => {