Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove TransactionSnapshot structure #4782

Merged

Conversation

xxuejie
Copy link
Collaborator

@xxuejie xxuejie commented Jan 15, 2025

As of now, TransactionSnapshot and TransactionState from ckb-script package are exactly the same. There is no need to keep them both.

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.
Title Only: Include only the PR title in the release note.
Note: Add a note under the PR title in the release note.

As of now, TransactionSnapshot and TransactionState from ckb-script
package are exactly the same. There is no need to keep them both.
@xxuejie xxuejie requested a review from a team as a code owner January 15, 2025 05:32
@xxuejie xxuejie requested review from quake and chenyukang and removed request for a team January 15, 2025 05:32
@zhangsoledad zhangsoledad added this pull request to the merge queue Jan 16, 2025
Merged via the queue into nervosnetwork:develop with commit b8f655a Jan 16, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants