Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new spawn #13
Support new spawn #13
Changes from 3 commits
a857ffa
cbf704d
24e5295
6162144
a5687b6
ad3cd0f
72a4f71
a68a701
975fbbe
84e07fe
848ac9b
af004df
fcb59f9
9c00d32
3fa8a38
00001a4
27db927
7422483
f6236ec
79b8dd9
513f90e
5e070fd
6946164
bf51d2c
a8f1419
1129816
437c5b8
63ef979
f3255bf
b623f11
a977a96
6fa43e1
f41ea4a
4e77e89
6b206dd
2bcd67c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you modify the original data here, but clone a copy of the data as the return value at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many places, the
next
step isHashMap::insert
. This way, the return is more convenient to use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be version 3 in the future, use
if SETUP.vm_version == 0
instead