chore: Add useful information to certain Error variants #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
force-pushed
the
error-revisit
branch
from
0ab6805
to
feb29be
Compare
This commit revisits Error type with additional information that would help debugging, such as addresses to access in memory errors, and segment vaddr in Elf errors. To preserve the required information, one additional assembly line is required in each WRITE operation of x64 implementation. The arm64 code does not suffer from any additional assembly code, in fact, we also took the liberty to reduce a few unnecessary arm64 assembly lines.
xxuejie
force-pushed
the
error-revisit
branch
from
feb29be
to
768347f
Compare
mohanson
reviewed
Dec 15, 2023
XuJiandong
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit revisits Error type with additional information that would help debugging, such as addresses to access in memory errors, and segment vaddr in Elf errors.
To preserve the required information, one additional assembly line is required in each WRITE operation of x64 implementation. The arm64 code does not suffer from any additional assembly code, in fact, we also took the liberty to reduce a few unnecessary arm64 assembly lines.