Skip to content

Commit

Permalink
Require constituant libraries to enforce versions
Browse files Browse the repository at this point in the history
The value of this library is that it saves time adding the base set of
Nerves dependencies to projects. If there's a problem with using certain
versions of libraries then that should be sorted out in the library
because not everyone will use `nerves_pack`. Specifying them here adds
to a step to maintenance.

This also removes dependabot. While I think there's value in testing
new library combinations. Dependabot would make updates that disallowed
old versions on major updates. The old versions still worked and this
could easily have introduced a unnecessary dependency version conflict.
  • Loading branch information
fhunleth committed Jun 26, 2024
1 parent d04eab9 commit edaae67
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 52 deletions.
25 changes: 0 additions & 25 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,24 +51,6 @@ jobs:
- _build
- deps

automerge:
docker:
- image: alpine:3.18.4
steps:
- run:
name: Install GitHub CLI
command: apk add --no-cache build-base github-cli
- run:
name: Attempt PR automerge
command: |
author=$(gh pr view "${CIRCLE_PULL_REQUEST}" --json author --jq '.author.login' || true)
if [ "$author" = "app/dependabot" ]; then
gh pr merge "${CIRCLE_PULL_REQUEST}" --auto --rebase || echo "Failed trying to set automerge"
else
echo "Not a dependabot PR, skipping automerge"
fi
workflows:
checks:
jobs:
Expand All @@ -77,10 +59,3 @@ workflows:
matrix:
parameters:
tag: *tags

- automerge:
requires: *tags
context: org-global
filters:
branches:
only: /^dependabot.*/
17 changes: 0 additions & 17 deletions .github/dependabot.yml

This file was deleted.

20 changes: 10 additions & 10 deletions mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ defmodule NervesPack.MixProject do

defp deps do
[
{:nerves_ssh, "~> 1.0"},
{:nerves_runtime, "~> 0.6"},
{:nerves_time, "~> 0.3"},
{:nerves_motd, "~> 0.1"},
{:ring_logger, "~> 0.8"},
{:vintage_net, "~> 0.10"},
{:vintage_net_direct, "~> 0.10"},
{:vintage_net_ethernet, "~> 0.10"},
{:vintage_net_wifi, "~> 0.10"},
{:mdns_lite, "~> 0.8"},
{:nerves_ssh, "> 0.0.0"},
{:nerves_runtime, "> 0.0.0"},
{:nerves_time, "> 0.0.0"},
{:nerves_motd, "> 0.0.0"},
{:ring_logger, "> 0.0.0"},
{:vintage_net, "> 0.0.0"},
{:vintage_net_direct, "> 0.0.0"},
{:vintage_net_ethernet, "> 0.0.0"},
{:vintage_net_wifi, "> 0.0.0"},
{:mdns_lite, "> 0.0.0"},

# Dev dependencies
{:ex_doc, "~> 0.22", only: :docs, runtime: false}
Expand Down

0 comments on commit edaae67

Please sign in to comment.